refactor: express command outcomes as message keys

Eighty-nine call sites spelled out the same four-line nest to say "fail
with localized message X":

    CommandResult.Failure(
        MessageFormatter.formatError(
            languageManager.getMessage("channel.ban.noPermission"),
        ),
    )

The pairing of formatError with getMessage was a convention held together
only by copy-paste, so changing how command errors are presented meant
touching all eighty-nine. fail() and ok() on LunaticCommandBase own that
pairing now, and the call sites read as the intent: fail("channel.ban.noPermission").

Three when(error) blocks turned out to map every arm to the same message,
and ChannelCreateCommand ran two parallel whens over one error to pick a
key and its parameters separately. Both were only visible once the noise
around them was gone.

Co-Authored-By: Claude <noreply@anthropic.com>

0 files changed, 0 insertions, 0 deletions