summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorfukachan <fukachan>2002-12-20 03:37:43 +0000
committerfukachan <fukachan>2002-12-20 03:37:43 +0000
commit50222718bc3b0970c4ac65524f8285fc493bf290 (patch)
treee0dda281ee859ffa85cecdfd4b87951de12a1075
parent0664bbe59e944fd5c8052124aca650368126e635 (diff)
downloadfml8-50222718bc3b0970c4ac65524f8285fc493bf290.tar.gz
fml8-50222718bc3b0970c4ac65524f8285fc493bf290.tar.bz2
fml8-50222718bc3b0970c4ac65524f8285fc493bf290.zip
clean up comments. add todo.
-rw-r--r--fml/lib/FML/CGI/ThreadTrack.pm17
1 files changed, 10 insertions, 7 deletions
diff --git a/fml/lib/FML/CGI/ThreadTrack.pm b/fml/lib/FML/CGI/ThreadTrack.pm
index 5edf2145..7fa14f32 100644
--- a/fml/lib/FML/CGI/ThreadTrack.pm
+++ b/fml/lib/FML/CGI/ThreadTrack.pm
@@ -4,14 +4,13 @@
# All rights reserved. This program is free software; you can
# redistribute it and/or modify it under the same terms as Perl itself.
#
-# $FML: ThreadTrack.pm,v 1.20 2002/09/11 23:18:03 fukachan Exp $
+# $FML: ThreadTrack.pm,v 1.21 2002/09/22 14:56:41 fukachan Exp $
#
package FML::CGI::ThreadTrack;
use strict;
-use vars qw(@ISA @EXPORT @EXPORT_OK $AUTOLOAD);
use Carp;
-
+use vars qw(@ISA @EXPORT @EXPORT_OK $AUTOLOAD);
use CGI qw/:standard/; # load standard CGI routines
use FML::Process::CGI;
@@ -83,7 +82,7 @@ sub html_end
}
-# Descriptions: main routine for thread control
+# Descriptions: main routine for thread control.
# run_cgi() can process request: list, show, change_status
# Arguments: OBJ($curproc) HASH_REF($args)
# Side Effects: none
@@ -92,7 +91,7 @@ sub run_cgi_main
{
my ($curproc, $args) = @_;
my $config = $curproc->{ config };
- my $myname = $config->{ program_name };
+ my $myname = $config->{ program_name }; # XXX-TODO: valid ?
my $ttargs = $curproc->_build_threadtrack_param($args);
my $action = $curproc->safe_param_action() || '';
@@ -107,6 +106,7 @@ sub run_cgi_main
}
elsif ($action eq 'show') {
my $id = $curproc->safe_param_article_id();
+ # XXX-TODO: do not call _XXX() internal method from outside.
my $tid = $thread->_create_thread_id_strings($id);
$thread->show($tid);
}
@@ -123,6 +123,7 @@ sub run_cgi_main
}
}
}
+ # XXX-TODO: ? clarify this message more.
else {
print "Warning: only administrator change status\n";
}
@@ -139,7 +140,7 @@ sub run_cgi_main
}
-# Descriptions: prepare basic parameter for Mail::ThreadTrack module
+# Descriptions: prepare basic parameters for Mail::ThreadTrack module
# Arguments: OBJ($curproc) HASH_REF($args)
# Side Effects: none
# Return Value: HASH_REF
@@ -150,7 +151,8 @@ sub _build_threadtrack_param
my $myname = $config->{ program_name };
my $option = $curproc->command_line_options();
- # argumente for thread track module
+ # prepare arguments for thread track module
+ # XXX-TODO: hmm, we should provide $curproc->util->article_id_max() ?
my $ml_name = $curproc->safe_param_ml_name();
my $thread_db_dir = $config->{ thread_db_dir };
my $spool_dir = $config->{ spool_dir };
@@ -189,6 +191,7 @@ sub run_cgi_navigator
my $config = $curproc->{ config };
my $action = $curproc->myname();
my $target = $config->{ thread_cgi_target_window } || '_top';
+ # XXX-TODO: we should provide $curproc->util->get_ml_list() method ?
my $ml_list = $curproc->get_ml_list($args);
my $ml_name = $config->{ ml_name };