summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorfukachan <fukachan>2004-03-24 01:32:03 +0000
committerfukachan <fukachan>2004-03-24 01:32:03 +0000
commit6fb47dc61e4cc4f54b03b7fae7d6378bbca65235 (patch)
treecab25db5d0f8177d75ff9ae6cc8ed187f2fc09cc
parente97ade5201afe3cf7352581f7af38de25aca7d58 (diff)
downloadfml8-6fb47dc61e4cc4f54b03b7fae7d6378bbca65235.tar.gz
fml8-6fb47dc61e4cc4f54b03b7fae7d6378bbca65235.tar.bz2
fml8-6fb47dc61e4cc4f54b03b7fae7d6378bbca65235.zip
clean up campaign around thread function.
rename function name: o thread_summary -> get_thread_summary o tohtml_thread_summary -> get_tohtml_thread_summary o msg_time -> get_time_from_header
-rw-r--r--fml/lib/Mail/Message/DB.pm18
-rw-r--r--fml/lib/Mail/Message/IMPLEMENTATION4
-rw-r--r--fml/lib/Mail/Message/TODO2
-rw-r--r--fml/lib/Mail/Message/ToHTML.pm8
4 files changed, 16 insertions, 16 deletions
diff --git a/fml/lib/Mail/Message/DB.pm b/fml/lib/Mail/Message/DB.pm
index 4db4628a..0209de3a 100644
--- a/fml/lib/Mail/Message/DB.pm
+++ b/fml/lib/Mail/Message/DB.pm
@@ -4,7 +4,7 @@
# All rights reserved. This program is free software; you can
# redistribute it and/or modify it under the same terms as Perl itself.
#
-# $FML: DB.pm,v 1.13 2004/01/24 09:03:59 fukachan Exp $
+# $FML: DB.pm,v 1.14 2004/02/15 04:38:37 fukachan Exp $
#
package Mail::Message::DB;
@@ -26,7 +26,7 @@ use lib qw(../../../../fml/lib
../../../../img/lib
);
-my $version = q$FML: DB.pm,v 1.13 2004/01/24 09:03:59 fukachan Exp $;
+my $version = q$FML: DB.pm,v 1.14 2004/02/15 04:38:37 fukachan Exp $;
if ($version =~ /,v\s+([\d\.]+)\s+/) { $version = $1;}
# special value
@@ -247,8 +247,8 @@ sub analyze
my ($self, $msg) = @_;
my $hdr = $msg->whole_message_header;
my $id = $self->get_key();
- my $month = $self->msg_time($hdr, 'yyyy/mm');
- my $subdir = $self->msg_time($hdr, 'yyyymm');
+ my $month = $self->get_time_from_header($hdr, 'yyyy/mm');
+ my $subdir = $self->get_time_from_header($hdr, 'yyyymm');
#
# XXX-TODO: analyze() must not be here ?
@@ -452,7 +452,7 @@ sub _analyze_thread
retrieve summary on thread et.al.
-=head2 thread_summary($id).
+=head2 get_thread_summary($id).
return the following thread summary around the primary key $id.
@@ -479,7 +479,7 @@ For example, supporse $id 5 and the thread link is (3 5 6):
# Arguments: OBJ($self) NUM($id)
# Side Effects: none
# Return Value: HASH_REF
-sub thread_summary
+sub get_thread_summary
{
my ($self, $id) = @_;
my ($fn_prev_id, $fn_next_id, $fn_prev_thread_id,
@@ -569,11 +569,11 @@ sub thread_summary
# Arguments: OBJ($self) NUM($id)
# Side Effects: none
# Return Value: HASH_REF
-sub tohtml_thread_summary
+sub get_tohtml_thread_summary
{
my ($self, $id) = @_;
my $db = $self->db_open();
- my $summary = $self->thread_summary($id);
+ my $summary = $self->get_thread_summary($id);
my $prev_id = $summary->{ prev_id };
my $next_id = $summary->{ next_id };
my $prev_thread_id = $summary->{ prev_thread_id };
@@ -799,7 +799,7 @@ sub _decode_mime_string
# Arguments: OBJ($self) OBJ($hdr) STR($type)
# Side Effects: none
# Return Value: STR
-sub msg_time
+sub get_time_from_header
{
my ($self, $hdr, $type) = @_;
diff --git a/fml/lib/Mail/Message/IMPLEMENTATION b/fml/lib/Mail/Message/IMPLEMENTATION
index cbec2ce7..94188f6f 100644
--- a/fml/lib/Mail/Message/IMPLEMENTATION
+++ b/fml/lib/Mail/Message/IMPLEMENTATION
@@ -4,13 +4,13 @@
get($table, $key)
set($table, $key, 4value)
- thread_summary($key)
+ get_thread_summary($key)
$msg ---> Mail::Message::ToHTML
| A
| |
new() | |
- add($msg) | | thread_summary()
+ add($msg) | | get_thread_summary()
set() | | get()
| |
V |
diff --git a/fml/lib/Mail/Message/TODO b/fml/lib/Mail/Message/TODO
index 3edafc5d..8bcaf5e4 100644
--- a/fml/lib/Mail/Message/TODO
+++ b/fml/lib/Mail/Message/TODO
@@ -1,4 +1,4 @@
-o msg_time() は、Utils へ?
+o get_time_from_header() は、Utils へ?
o set_article_file_path() / get_article_file_path() ?
diff --git a/fml/lib/Mail/Message/ToHTML.pm b/fml/lib/Mail/Message/ToHTML.pm
index 90c9394b..5684416c 100644
--- a/fml/lib/Mail/Message/ToHTML.pm
+++ b/fml/lib/Mail/Message/ToHTML.pm
@@ -4,7 +4,7 @@
# All rights reserved. This program is free software; you can
# redistribute it and/or modify it under the same terms as Perl itself.
#
-# $FML: ToHTML.pm,v 1.63 2004/02/15 04:38:37 fukachan Exp $
+# $FML: ToHTML.pm,v 1.64 2004/02/24 14:36:53 fukachan Exp $
#
package Mail::Message::ToHTML;
@@ -17,7 +17,7 @@ my $debug = 0;
my $URL =
"<A HREF=\"http://www.fml.org/software/\">Mail::Message::ToHTML</A>";
-my $version = q$FML: ToHTML.pm,v 1.63 2004/02/15 04:38:37 fukachan Exp $;
+my $version = q$FML: ToHTML.pm,v 1.64 2004/02/24 14:36:53 fukachan Exp $;
my $versionid = 0;
if ($version =~ /,v\s+([\d\.]+)\s+/) {
$versionid = "$1";
@@ -394,7 +394,7 @@ sub _html_file_subdir_name
if ($subdir_style eq 'yyyymm') {
my $hdr = $self->{ _current_hdr };
- $subdir = $ndb->msg_time($hdr, 'yyyymm');
+ $subdir = $ndb->get_time_from_header($hdr, 'yyyymm');
use File::Spec;
my $xsubdir = File::Spec->catfile($html_base_dir, $subdir);
@@ -1179,7 +1179,7 @@ sub evaluate_links_relation
my ($self, $id) = @_;
my $ndb = $self->ndb();
- return $ndb->tohtml_thread_summary($id);
+ return $ndb->get_tohtml_thread_summary($id);
}